View Issue Details

IDProjectCategoryView StatusLast Update
0001186fss5pv210_LinuxSPIpublic2014-01-28 11:43
ReporterKeller Assigned To 
Status resolvedResolutionfixed 
Product VersionarmStoneA8-V1.1 
Target Versionfss5pv210-V2.0Fixed in Versionfss5pv210-V2.0 
Summary0001186: Fix max_speed_hz computation for S3C64XX SPI
DescriptionThe computation for the maximum possible speed in drivers/spi/spi-s3c64xx.c is too complicated and could be wrong in some cases.
Forum Link



2012-08-03 11:02

manager   ~0000748

Last edited: 2012-08-03 11:04

Don't AND with PSR_MASK, but check for greater than instead. Using AND could cause wrong results if the remaining value was again rather small.

In addition we can use a computation that directly computes the desired psr. We don't need to recompute the resulting speed and then adjust psr if too high.