View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0001186 | fss5pv210_Linux | SPI | public | 2012-08-03 10:59 | 2014-01-28 11:43 |
Reporter | Keller | Assigned To | |||
Priority | normal | Severity | minor | Reproducibility | sometimes |
Status | resolved | Resolution | fixed | ||
Product Version | armStoneA8-V1.1 | ||||
Target Version | fss5pv210-V2.0 | Fixed in Version | fss5pv210-V2.0 | ||
Summary | 0001186: Fix max_speed_hz computation for S3C64XX SPI | ||||
Description | The computation for the maximum possible speed in drivers/spi/spi-s3c64xx.c is too complicated and could be wrong in some cases. | ||||
Forum Link | |||||
|
Don't AND with PSR_MASK, but check for greater than instead. Using AND could cause wrong results if the remaining value was again rather small. In addition we can use a computation that directly computes the desired psr. We don't need to recompute the resulting speed and then adjust psr if too high. |