View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005051 | UBoot | U-Boot | public | 2021-10-28 13:03 | 2021-10-28 14:23 |
| Reporter | derksen | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | resolved | Resolution | fixed | ||
| Product Version | fsimx8mn-Y2021.09 | ||||
| Target Version | fsimx6-B2021.10 | Fixed in Version | fsimx6-B2021.10 | ||
| Summary | 0005051: net: nfs: remove superfluous conversions | ||||
| Description | net: nfs: remove superfluous conversions rpc_pkt.u.call.data is an array of uint32_t. There is no need to convert it to uint32_t *. memcpy() expects void * as it 1st and 2nd argument. There is no point in converting pointers to char * before passing them to memcpy(). In ntohl(data[1]) != 0 calling ntohl() is superfluous. If the value is zero, does not depend on the byte order. | ||||
| Additional Information | External patch: Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> Reviewed-by: Bin Meng <bmeng.cn@gmail.com> Acked-by: Joe Hershberger <joe.hershberger@ni.com> | ||||
| Forum Link | |||||
